Skip to content

YARN-11873. Add yarn.lock for app catalog webapp #8020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2025
Merged

YARN-11873. Add yarn.lock for app catalog webapp #8020

merged 1 commit into from
Oct 13, 2025

Conversation

MikaelSmith
Copy link
Contributor

@MikaelSmith MikaelSmith commented Oct 8, 2025 •
edited by slfan1989
Loading

Description of PR

JIRA: YARN-11873. Add yarn.lock for app catalog webapp

Adds a yarn.lock to ensure reproducible npm builds with hadoop-yarn-applications-catalog-webapp.

How was this patch tested?

Compiled the module. This just preserves the file that's already generated.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@MikaelSmith
YARN-11873. Add yarn.lock for app catalog webapp
0c33c18 
Adds a yarn.lock to ensure reproducible npm builds with
hadoop-yarn-applications-catalog-webapp.
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 shadedclient 38m 39s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 shadedclient 34m 10s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 39s The patch does not generate ASF License warnings.
75m 50s
Subsystem Report/Notes
Docker ClientAPI=1.51 ServerAPI=1.51 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8020/1/artifact/out/Dockerfile
GITHUB PR #8020
Optional Tests dupname asflicense codespell detsecrets
uname Linux 72e5f0776f34 5.15.0-152-generic #162-Ubuntu SMP Wed Jul 23 09:48:42 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 0c33c18
Max. process+thread count 759 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-8020/1/console
versions git=2.25.1 maven=3.9.11
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@slfan1989 slfan1989 requested a review from iwasakims October 9, 2025 00:37
@slfan1989
Copy link
Contributor

@iwasakims Could you please help review this PR? Thank you very much!

@slfan1989 slfan1989 merged commit e07a874 into apache:trunk Oct 13, 2025
4 checks passed
@slfan1989
Copy link
Contributor

@MikaelSmith Thanks for the contribution! Merged into trunk.

@slfan1989
Copy link
Contributor

@MikaelSmith Could we also submit this PR to the branch-3.4?

@MikaelSmith
Copy link
Contributor Author

I generated it by running yarn install (via mvn compile) and adding the lockfile generated. If package.json is the same in branch-3.4, then this file should be the same and we can directly apply this patch.

@MikaelSmith MikaelSmith deleted the yarn-11873 branch October 13, 2025 16:15
@MikaelSmith
Copy link
Contributor Author

I don't see any difference between them

git diff upstream/trunk upstream/branch-3.4 -- hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/package.json

so it should be safe to cherry-pick this change to branch-3.4.

steveloughran pushed a commit that referenced this pull request Oct 16, 2025
@MikaelSmith @steveloughran
YARN-11873. Add yarn.lock for app catalog webapp (#8020)
6ea74f9 
Contributed by Michael Smith

*Adds a yarn.lock to ensure reproducible npm builds with hadoop-yarn-applications-catalog-webapp.

Signed-off-by: Shilun Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slfan1989 slfan1989 slfan1989 approved these changes

@iwasakims iwasakims Awaiting requested review from iwasakims

Assignees

No one assigned

Labels

trunk YARN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MikaelSmith @hadoop-yetus @slfan1989